Skip to content

test: unskip v8-updates/test-linux-perf-logger #52869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lukealbao wants to merge 4 commits into from
Closed

test: unskip v8-updates/test-linux-perf-logger #52869

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cdc89d0
test: unskip v8-updates/test-linux-perf-logger
lukealbao May 7, 2024
03f1dda
test: Revert "test: skip v8-updates/test-linux-perf-logger"
lukealbao May 7, 2024
d261dfa
lint fix
lukealbao May 7, 2024
62cef20
lint fix indent
lukealbao May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
lint fix
  • Loading branch information
@lukealbao
lukealbao committed May 7, 2024
commit d261dfabfe1426cdcc9804377282b422482c13ce
6 changes: 4 additions & 2 deletions test/v8-updates/test-linux-perf-logger.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,8 @@ const testCases = [
},
{
title: '--perf-basic-prof compiled',
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan', '--minimum-invocations-before-optimization=0'],
nodeFlags: ['--perf-basic-prof', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'test-regex',
'~functionOne .+/linux-perf-logger.js',
Expand All @@ -70,7 +71,8 @@ const testCases = [
},
{
title: '--perf-basic-prof-only-functions compiled',
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan', '--minimum-invocations-before-optimization=0'],
nodeFlags: ['--perf-basic-prof-only-functions', '--no-turbo-inlining', '--always-turbofan',
'--minimum-invocations-before-optimization=0'],
matches: [
'~functionOne .+/linux-perf-logger.js',
'~functionTwo .+/linux-perf-logger.js',
Expand Down