Skip to content

src: fix positional args in task runner #52810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
May 8, 2024
+109 −44
Merged

src: fix positional args in task runner #52810

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
9db1469
src: fix positional args in task runner
anonrig May 2, 2024
62564bb
fix: improve windows support
lemire May 3, 2024
66e0721
fix: update tests
lemire May 3, 2024
9a44f9e
lint
lemire May 3, 2024
4989987
use correct value
anonrig May 4, 2024
7505902
simplify windows tests
anonrig May 5, 2024
f388eec
fix cctests
anonrig May 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use correct value
  • Loading branch information
@anonrig
anonrig committed May 6, 2024
commit 4989987dc649593e2f5764238f08c32bd37a23ad
2 changes: 1 addition & 1 deletion src/node_task_runner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ std::string EscapeShell(const std::string_view input) {
// Passing "--help "sdfsd"" to a batch script
// will be considered as a single argument made
// of --help "sdfsd". However, there are corner cases.
std::string escaped = "\"" + escaped + "\"";
std::string escaped = "\"" + std::string(input) + "\"";
#else
// Replace single quotes("'") with "\\'"
std::string escaped =
Expand Down
10 changes: 6 additions & 4 deletions test/fixtures/run-script/node_modules/.bin/positional-args.bat
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.