Skip to content

build: add missing libnode.lib and copy debug build if built #52442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
segevfiner wants to merge 2 commits into from
Closed

build: add missing libnode.lib and copy debug build if built #52442

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
619768a
build: fix headers install for shared mode on Windows
segevfiner Mar 30, 2024
a88e4a8
build: add missing libnode.lib and copy debug build if built
segevfiner Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
build: fix headers install for shared mode on Windows
  • Loading branch information
@segevfiner
segevfiner committed Mar 30, 2024
commit 619768aeef65eaebc7c3b52f714ae1498858a279
2 changes: 1 addition & 1 deletion vcbuild.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ if defined dll (
copy /Y node.def %TARGET_NAME%\Release\ > nul
if errorlevel 1 echo Cannot copy node.def && goto package_error

python ..\tools\install.py install --dest-dir %CD%\%TARGET_NAME% --prefix \ --headers-only --silent
python ..\tools\install.py install --root-dir .. --config-gypi-path %CD%\..\config.gypi --dest-dir %CD%\%TARGET_NAME% --prefix \ --headers-only
if errorlevel 1 echo Cannot install headers && goto package_error
)
cd ..
Expand Down