Skip to content

build: fix warning in cares under GN build #51687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zcbenz wants to merge 1 commit into from
Closed

build: fix warning in cares under GN build #51687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: fix warning in cares under GN build 
This change can be removed after the upstream fix lands in Node:
c-ares/c-ares#709
  • Loading branch information
@zcbenz
zcbenz committed Feb 23, 2024
commit c01e971c612041088e94a0977f1f7d6fc858db92
2 changes: 2 additions & 0 deletions deps/cares/unofficial.gni
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ template("cares_gn_build") {
cflags_c = [
"-Wno-implicit-fallthrough",
"-Wno-unreachable-code",
# Remove after https://github.com/c-ares/c-ares/pull/709 lands in Node.
"-Wno-unused-result",
]
}
}
Expand Down