Skip to content

tools: avoid npm install in deps installation #50413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Oct 30, 2023
Merged

tools: avoid npm install in deps installation #50413

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
49fb34a
tools: avoid npm install in deps installation
marco-ippolito Oct 26, 2023
77fd983
fix
marco-ippolito Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
tools: avoid npm install in deps installation
  • Loading branch information
@marco-ippolito
marco-ippolito committed Oct 26, 2023
commit 49fb34a51546dbc2ca86b8a7523e92c0a1945b97
38 changes: 28 additions & 10 deletions tools/dep_updaters/update-acorn-walk.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,12 @@

set -ex

BASE_DIR=$(cd "$(dirname "$0")/../.." && pwd)
Comment thread
marco-ippolito marked this conversation as resolved.
ROOT=$(cd "$(dirname "$0")/../.." && pwd)
[ -z "$NODE" ] && NODE="$ROOT/out/Release/node"
[ -x "$NODE" ] || NODE=$(command -v node)
NPM="$ROOT/deps/npm/bin/npm-cli.js"
DEPS_DIR="$BASE_DIR/deps"

# shellcheck disable=SC1091
. "$ROOT/tools/dep_updaters/utils.sh"
Expand All @@ -23,21 +25,37 @@ compare_dependency_version "acorn-walk" "$NEW_VERSION" "$CURRENT_VERSION"

cd "$( dirname "$0" )/../.." || exit

rm -rf deps/acorn/acorn-walk
echo "Making temporary workspace..."

(
rm -rf acorn-walk-tmp
mkdir acorn-walk-tmp
cd acorn-walk-tmp || exit
WORKSPACE=$(mktemp -d 2> /dev/null || mktemp -d -t 'tmp')

"$NODE" "$NPM" init --yes
cleanup () {
EXIT_CODE=$?
[ -d "$WORKSPACE" ] && rm -rf "$WORKSPACE"
exit $EXIT_CODE
}

"$NODE" "$NPM" install --global-style --no-bin-links --ignore-scripts "acorn-walk@$NEW_VERSION"
)
trap cleanup INT TERM EXIT

mv acorn-walk-tmp/node_modules/acorn-walk deps/acorn
cd "$WORKSPACE"

rm -rf acorn-walk-tmp/
echo "Fetching ada source archive..."
Comment thread
marco-ippolito marked this conversation as resolved.
Outdated

DIST_URL=$(curl -sL "https://registry.npmjs.org/acorn-walk/$NEW_VERSION" | perl -n -e '/"dist".*?"tarball":"(.*?)"/ && print $1')

ACORN_WALK_TGZ="acorn-walk.tgz"

curl -sL -o "$ACORN_WALK_TGZ" "$DIST_URL"

log_and_verify_sha256sum "acorn-walk" "$ACORN_WALK_TGZ"

rm -r "$DEPS_DIR/acorn/acorn-walk"/*

tar -xf "$ACORN_WALK_TGZ"

mv "$WORKSPACE/package"/* "$DEPS_DIR/acorn/acorn-walk"

@lpinca lpinca Oct 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mv "$WORKSPACE/package"/* "$DEPS_DIR/acorn/acorn-walk"
mv package/* "$DEPS_DIR/acorn/acorn-walk"


rm "$ACORN_WALK_TGZ"

@lpinca lpinca Oct 27, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
rm "$ACORN_WALK_TGZ"

Removed on cleanup.


echo "All done!"
echo ""
Expand Down