Skip to content

stream,doc: make writable.setDefaultEncoding() return this #5040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calvinmetcalf merged 1 commit into from
Apr 30, 2016
Merged

stream,doc: make writable.setDefaultEncoding() return this #5040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
stream,doc: make writable.setDefaultEncoding() return this 
Let this function return `this` for parity with `readable.setEncoding()` (#5013).
  • Loading branch information
@estliberitas
estliberitas committed Apr 29, 2016
commit 46f4f9a439cc047c8aa98180c6732dc13b7b355e
1 change: 1 addition & 0 deletions doc/api/stream.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,6 +695,7 @@ file.end('world!');
#### writable.setDefaultEncoding(encoding)

* `encoding` {String} The new default encoding
* Return: `this`

Sets the default encoding for a writable stream.

Expand Down
1 change: 1 addition & 0 deletions lib/_stream_writable.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,6 +251,7 @@ Writable.prototype.setDefaultEncoding = function setDefaultEncoding(encoding) {
if (!Buffer.isEncoding(encoding))
throw new TypeError('Unknown encoding: ' + encoding);
this._writableState.defaultEncoding = encoding;
return this;
};

function decodeChunk(state, chunk, encoding) {
Expand Down