Skip to content

tools: run coverage CI only on relevant files #50349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Oct 25, 2023
Merged

tools: run coverage CI only on relevant files #50349

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d0ccae
tools: run coverage CI only on relevant files
aduh95 Oct 23, 2023
09c3462
fixup! tools: run coverage CI only on relevant files
aduh95 Oct 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! tools: run coverage CI only on relevant files
  • Loading branch information
@aduh95
aduh95 committed Oct 23, 2023
commit 09c3462481d4bef5739dd841e2622965d8250137
10 changes: 8 additions & 2 deletions .github/workflows/coverage-linux-without-intl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,24 @@ on:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- test/**/*
- test/**
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux-without-intl.yml
push:
branches:
- main
paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- test/**/*
- test/**
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux-without-intl.yml

concurrency:
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/coverage-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,24 @@ on:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- test/**/*
- test/**
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux.yml
Comment on lines +6 to +14

@richardlau richardlau Oct 23, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Theoretically changes to the Python test runner and/or build files (Makefile, gyp files) could also affect coverage results.

push:
branches:
- main
paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- test/**/*
- test/**
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-linux.yml

concurrency:
Expand Down
10 changes: 8 additions & 2 deletions .github/workflows/coverage-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,24 @@ on:
types: [opened, synchronize, reopened, ready_for_review]
paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- test/**/*
- test/**
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-windows.yml
push:
branches:
- main
paths:
- lib/**/*.js
- Makefile
- src/**/*.cc
- src/**/*.h
- test/**/*
- test/**
- tools/gyp/**
- tools/test.py
- .github/workflows/coverage-windows.yml

concurrency:
Expand Down