Skip to content

esm: bypass CommonJS loader under --default-type=module #49986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 11 commits into from
Oct 5, 2023
Merged

esm: bypass CommonJS loader under --default-type=module #49986

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
97b1966
esm: bypass CommonJS loader under --default-type
GeoffreyBooth Oct 1, 2023
30821db
Streamline
GeoffreyBooth Oct 1, 2023
286c632
Revert "Streamline"
GeoffreyBooth Oct 1, 2023
4620842
Move/improve tests; decorate "not found" error to provide hint about …
GeoffreyBooth Oct 1, 2023
bdafa66
Update docs
GeoffreyBooth Oct 2, 2023
83884e5
Fix for Windows
GeoffreyBooth Oct 2, 2023
162b6fa
Move out main re-resolution
GeoffreyBooth Oct 4, 2023
22bddbd
Optimize
GeoffreyBooth Oct 5, 2023
6c97b9a
Revert "Optimize"
GeoffreyBooth Oct 5, 2023
32aaabc
Update lib/internal/modules/run_main.js
GeoffreyBooth Oct 5, 2023
038dfb8
Return early if possible
GeoffreyBooth Oct 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Move out main re-resolution
  • Loading branch information
@GeoffreyBooth
GeoffreyBooth committed Oct 5, 2023
commit 162b6fa219552575ccca45ac4d8fc79beb750009
3 changes: 1 addition & 2 deletions lib/internal/modules/run_main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,9 @@ function shouldUseESMLoader(mainPath) {
function runMainESM(mainPath) {
const { loadESM } = require('internal/process/esm_loader');
const { pathToFileURL } = require('internal/url');
const main = pathToFileURL(mainPath).href;

handleMainPromise(loadESM((esmLoader) => {
const main = path.isAbsolute(mainPath) ?
pathToFileURL(mainPath).href : mainPath;
return esmLoader.import(main, undefined, { __proto__: null });
}));
}
Expand Down