Skip to content

console: treat non-strings as separate argument in console.assert() #49722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
Nov 1, 2023
Merged

console: treat non-strings as separate argument in console.assert() #49722

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9ac6528
console: treat non-strings as separate argument in console.assert()
jcbhmr Sep 19, 2023
4f4db4d
add console.assert(false, Symbol()) test
jcbhmr Sep 21, 2023
b6e5492
fix formatting
jcbhmr Sep 21, 2023
8240194
formatting
jcbhmr Sep 21, 2023
cc93b2a
LF
jcbhmr Sep 21, 2023
4c905fc
single quotes
jcbhmr Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
console: treat non-strings as separate argument in console.assert() 
fixes #49680
  • Loading branch information
@jcbhmr
jcbhmr authored Sep 19, 2023
commit 9ac6528588ea7785b99e4433381cfa523591db87
7 changes: 6 additions & 1 deletion lib/internal/console/constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,7 +432,12 @@ const consoleMethods = {

assert(expression, ...args) {
if (!expression) {
args[0] = `Assertion failed${args.length === 0 ? '' : `: ${args[0]}`}`;
// https://console.spec.whatwg.org/#assert step 4.2:
if (typeof args[0] === "string") {
args[0] = `Assertion failed: ${args[0]}`
} else {
ArrayPrototypeUnshift(args, "Assertion failed")
}

@BridgeAR BridgeAR Sep 19, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// https://console.spec.whatwg.org/#assert step 4.2:
if (typeof args[0] === "string") {
args[0] = `Assertion failed: ${args[0]}`
} else {
ArrayPrototypeUnshift(args, "Assertion failed")
}
let baseMessage = 'Assertion failed';
if (args.length > 0) {
baseMessage += ':';
}
ArrayPrototypeUnshift(args, "Assertion failed");

That way it's always consistent and I would not add the documentation reference as it might change it's location without the comment being updated.

// The arguments will be formatted in warn() again
ReflectApply(this.warn, this, args);
}
Expand Down