Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v20.6.0 proposal #49185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
v20.6.0 proposal #49185
Changes from 1 commit
5aef593d5e93b11f35c0c30ea480ea54784c3dbd0c41cc3ef07d0fd6318e075e01cce567f9896e69c8e130fb7b7fe2052884c0c68a5597471761bdf609b25f41929a2388c7d9409cc69aeac3270a4f7c6d649339d759d4f24c37424515a28c8e17822a7835cd92b0135dec186ed2342641058bec20d35d3680a66420b85c4bd5e55be7b511578c3d1d960ee065d239453ee985015c4f7b12c3b5045e3c5742597b0cd23935e47308092f9fe4b0e505660da78bc009d0d634d78c14ff695173c55e0fdb7b62a46d9a5322c46b27bb0a12ce110db104aa129962b79b292f3d62ab314bd60fa19b0e771abcb60d61415ccfb8d52c9490913666762e23f8b5991f5d4398d4114e088b4ca4a66ead861e09a6b4c1bd6809138b787b9adff6c389df9641ac674a2e1e386e82640103ad22fc2a64f88cb1458eaf56c3e5c4b3a7427821b11ab945d7b7186e029c26c0fb82f05ca5f37176ce25f8ed065bc195885c48f8ccf7e7b554e9d9ca19d13503669ac03f23b2a3e70e9747816e043d36e7adb4370ff126b9e89fa3faf888a1d2fcb8558380800dca8678d568600b79c6523d942d9e5b0dfa497df8245c860057b24a389b1bce13bd7a01a6e945eb12158600c08d31442b9b66a3c1aa4caf891d41e7b0300048d6948fbfaa0fb032107a995cbf9e14f04595a6e76347175821dc8441d17c103ddb1554439327b3c56d2661b0556595367750cca221949c4bf7ff36f71e38300fc8bbd6862b0f2f4ce9099159c97003446b5d5b2File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Original commit message: Fix mistake in the skip branch of test/mjsunit/regress-1320641.js It was doing a `string.test(regex)` which was wrong. It's supposed to be `regex.test(string)`. It wasn't caught in the CI because the skip path is not normally taken in the V8 CI. Change-Id: Id1bdab5bbc41968bba8adc1cb3664e8f95fb5d72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4697855 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Cr-Commit-Position: refs/heads/main@{#89044} Refs: v8/v8@9f4b769 PR-URL: #48830 Refs: v8/v8@c1a54d5 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Debadree Chatterjee <debadree333@gmail.com>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing