Skip to content

src: pre-emptively fix tests broken by V8 CL #48671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kvakil wants to merge 2 commits into from
Closed

src: pre-emptively fix tests broken by V8 CL #48671

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81a2cfe
src: remove kEagerCompile for CompileFunction
kvakil Jul 6, 2023
64583df
deps: V8: cherry-pick cb00db4dba6c
kvakil Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
src: remove kEagerCompile for CompileFunction 
It wasn't doing anything, and actually enabling it would cause some
tests to fail.

Refs: #48576
  • Loading branch information
@kvakil
kvakil committed Jul 6, 2023
commit 81a2cfede4805af1dcd9cf836fa4a04ec1507008
2 changes: 1 addition & 1 deletion src/node_builtins.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ MaybeLocal<Function> BuiltinLoader::LookupAndCompileInternal(
const bool has_cache = cached_data.data != nullptr;
ScriptCompiler::CompileOptions options =
has_cache ? ScriptCompiler::kConsumeCodeCache
: ScriptCompiler::kEagerCompile;
: ScriptCompiler::kNoCompileOptions;
ScriptCompiler::Source script_source(
source,
origin,
Expand Down
2 changes: 1 addition & 1 deletion src/node_snapshotable.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1270,7 +1270,7 @@ void CompileSerializeMain(const FunctionCallbackInfo<Value>& args) {
parameters.data(),
0,
nullptr,
ScriptCompiler::kEagerCompile)
ScriptCompiler::kNoCompileOptions)
.ToLocal(&fn)) {
args.GetReturnValue().Set(fn);
}
Expand Down