Skip to content

test-runner: run tests as soon as find them #48584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rluvaton wants to merge 20 commits into from
Closed

test-runner: run tests as soon as find them #48584

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1d80a2b
test_runner: run tests as soon as find them
rluvaton Jun 28, 2023
20e7ad9
test-runner: fix tests as files not run in consistent order...
rluvaton Jun 28, 2023
299cd6d
test: use hard-coded pattern
rluvaton Jun 28, 2023
13f003e
Update lib/internal/test_runner/runner.js
rluvaton Jun 28, 2023
a3f7575
Update lib/internal/test_runner/runner.js
rluvaton Jun 28, 2023
00259ee
test_runner: check node stream
rluvaton Jun 28, 2023
1164a4a
Merge remote-tracking branch 'origin/run-tests-as-soon-as-get-a-file'…
rluvaton Jun 28, 2023
afd0658
test_runner: lint
rluvaton Jun 28, 2023
cebf726
test_runner: add comment
rluvaton Jun 28, 2023
1d68c63
test_runner: fix concurrent test
rluvaton Jun 28, 2023
0ea199f
test_runner: format
rluvaton Jun 28, 2023
98a9614
test_runner: improve error message in test
rluvaton Jun 28, 2023
004e915
test_runner: fix exit code test
rluvaton Jun 28, 2023
0cb655f
test_runner: revert termination handler process.exit(1)
rluvaton Jun 28, 2023
2062f53
test_runner: termination handler process.exit(1)
rluvaton Jun 28, 2023
517bdbc
test_runner: remove todo
rluvaton Jun 28, 2023
5d34f67
test_runner: add signal support for glob
rluvaton Jun 28, 2023
4461789
test_runner: simplify runner
rluvaton Jun 28, 2023
773f3cf
test_runner: remove comment
rluvaton Jun 28, 2023
dd09109
test_runner: remove todo
rluvaton Jun 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: fix concurrent test
  • Loading branch information
@rluvaton
rluvaton committed Jun 28, 2023
commit 1d68c63602061d37fe916db2bab7a444d8b19c29
3 changes: 2 additions & 1 deletion lib/internal/test_runner/runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const {
StringPrototypeStartsWith,
TypedArrayPrototypeGetLength,
TypedArrayPrototypeSubarray,
NumberMAX_SAFE_INTEGER
} = primordials;

const { spawn } = require('child_process');
Expand Down Expand Up @@ -481,7 +482,7 @@ function run(options) {

if (isNodeStream(testFiles)) {
return testFiles
.map(runSingleFile, { __proto__: null, signal, concurrency })
.map(runSingleFile, { __proto__: null, signal, concurrency: NumberMAX_SAFE_INTEGER })

@rluvaton rluvaton Jun 28, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

used this concurrency to not wait for tests otherwise tests that not finish not allow us to run other tests, and this is also to keep the behavior of AllSettled...

will be changed to Infinity once the below PR is merged:

.toArray();
}

Expand Down
3 changes: 0 additions & 3 deletions test/parallel/test-runner-concurrency.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,9 +88,6 @@ describe('concurrency: true implies Infinity', { concurrency: true }, () => {
}

test('--test multiple files', { skip: os.availableParallelism() < 3 }, async () => {

// TODO - fix this test, it failed due to concurrency not being set you
// waiting for first to finish before starting other
await fs.writeFile(path.resolve(tmpdir.path, 'test-runner-concurrency'), '');
const { code, stderr } = await common.spawnPromisified(process.execPath, [
'--test',
Expand Down