Skip to content

src: fix Coverity issue regarding unnecessary copy #48565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Jun 28, 2023
Merged

src: fix Coverity issue regarding unnecessary copy #48565

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
src: fix Coverity issue regarding unnecessary copy
  • Loading branch information
@anonrig
anonrig committed Jun 26, 2023
commit 36a30f429a68c65fe29c431c2d8852af4b99d41d
2 changes: 1 addition & 1 deletion src/node_v8_platform-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ struct V8Platform {
constexpr auto convert_to_set =
[](std::vector<std::string_view> categories) -> std::set<std::string> {
std::set<std::string> out;
for (const auto s : categories) {
for (const auto& s : categories) {
out.emplace(s);
}
return out;
Expand Down