Skip to content

fs, stream: add initial Symbol.dispose and Symbol.asyncDispose support #48518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 10 commits into from
Jun 25, 2023
Merged

fs, stream: add initial Symbol.dispose and Symbol.asyncDispose support #48518

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8a25397
fs, stream: initial `Symbol.dispose` and `Symbol.asyncDispose` support
MoLow Jun 22, 2023
8dc2ee7
Update lib/internal/process/pre_execution.js
MoLow Jun 22, 2023
223a2d8
Update lib/internal/streams/readable.js
MoLow Jun 22, 2023
40ba972
lint
MoLow Jun 22, 2023
e8a014f
Update lib/internal/streams/readable.js
benjamingr Jun 22, 2023
48602bb
Update lib/internal/streams/readable.js
benjamingr Jun 22, 2023
39b6ace
eslint disable
MoLow Jun 22, 2023
a6d798d
CR
MoLow Jun 22, 2023
98285ae
docs: add experimental
MoLow Jun 23, 2023
5d0d435
Update doc/api/stream.md
benjamingr Jun 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update lib/internal/process/pre_execution.js 
Co-authored-by: Robert Nagy <ronagy@icloud.com>
  • Loading branch information
@MoLow @ronag
MoLow and ronag authored Jun 22, 2023
commit 8dc2ee76069b755abdb1e6ecfed138ae1b012c0d
1 change: 0 additions & 1 deletion lib/internal/process/pre_execution.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,6 @@ function setupSymbolDisposePolyfill() {
Symbol.asyncDispose ??= SymbolAsyncDispose;

@mcollina mcollina Jun 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be a good thing to polyfill them? Wouldn't users assume certain behaviors from the runtime because they exists?

@MoLow MoLow Jun 22, 2023

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is a way for typescript or bable to recognize these symbols without them being global.

@benjamingr benjamingr Jun 22, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcollina this is confirmed (with the TS team) to play nice. Users would be able to use them with the polyfill but not the syntactic sugar until v8 ships

@zloirock zloirock Jul 7, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That breaks core-js.

@zloirock zloirock Jul 7, 2023

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#48699

}


function setupUserModules(isLoaderWorker = false) {
initializeCJSLoader();
initializeESMLoader(isLoaderWorker);
Expand Down