Skip to content

test: use unusual chars in the path to ensure our tests are robust #48409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 13 commits into from
Dec 30, 2024
Merged

test: use unusual chars in the path to ensure our tests are robust #48409

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
d549709
test: use unusual chars in the path to ensure our tests are robust
aduh95 Jun 10, 2023
83fafd7
fix more tests with wrong assumptions
aduh95 Jun 24, 2023
36cb9b2
skip tests that are hopeless
aduh95 Jul 2, 2023
17f82c4
attempt at fixing more tests
aduh95 Aug 22, 2024
f74e391
more parallelism
aduh95 Aug 22, 2024
120ba50
fix lint
aduh95 Sep 22, 2024
bf9990f
test: make inspector strip type pass when path contains unusual chars
aduh95 Sep 23, 2024
c848536
unusual chars in macOS
aduh95 Sep 23, 2024
b906e1d
fix workflow files
aduh95 Sep 23, 2024
6d1d2c6
skip tests that crash
aduh95 Sep 29, 2024
f594d73
fixup! skip tests that are hopeless
aduh95 Oct 18, 2024
73bc723
fixup! attempt at fixing more tests
aduh95 Dec 23, 2024
55edf5d
fixup! attempt at fixing more tests
aduh95 Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix workflow files
  • Loading branch information
@aduh95
aduh95 committed Dec 22, 2024
commit b906e1d027cbf4dea24badc9cecfa152c9a38149
8 changes: 5 additions & 3 deletions .github/workflows/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,11 @@ jobs:
- name: Build
run: make -C node build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn"
- name: Test
run: make -C node run-ci -j4 V=1 TEST_CI_ARGS="-p actions --measure-flakiness 9"
run: make -C node run-ci -j4 V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9"
- name: Re-run test in a folder whose name contains unusual chars

@RafaelGSS RafaelGSS Dec 17, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it mean we'll double the time to run the tests in the GH Actions?

@aduh95 aduh95 Dec 17, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you see in this PR, it adds about 10 minutes (a bit less on Linux)

run: |
mv node 'dir%20with unusual"chars '"'"'åß∂ƒ©∆¬…`'
cd 'dir%20with unusual"chars '"'"'åß∂ƒ©∆¬…`'
mv node "$DIR"
cd "$DIR"
./tools/test.py --flaky-tests keep_retrying -p actions -j 4
env:
DIR: dir%20with $unusual"chars?'åß∂ƒ©∆¬…`
7 changes: 4 additions & 3 deletions .github/workflows/test-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ jobs:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
with:
persist-credentials: false
path: node
- name: Set up Python ${{ env.PYTHON_VERSION }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
Expand Down Expand Up @@ -84,15 +85,15 @@ jobs:
df -h
echo "::endgroup::"
- name: Build
run: make build-ci -j$(getconf _NPROCESSORS_ONLN) V=1 CONFIG_FLAGS="--error-on-warn"
run: make -C node build-ci -j$(getconf _NPROCESSORS_ONLN) V=1 CONFIG_FLAGS="--error-on-warn"
- name: Free Space After Build
run: df -h
- name: Test
run: make run-ci -j$(getconf _NPROCESSORS_ONLN) V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9"
run: make -C node run-ci -j$(getconf _NPROCESSORS_ONLN) V=1 TEST_CI_ARGS="-p actions --node-args='--test-reporter=spec' --node-args='--test-reporter-destination=stdout' --measure-flakiness 9"
- name: Re-run test in a folder whose name contains unusual chars
run: |
mv node "$DIR"
cd "$DIR"
./tools/test.py --flaky-tests keep_retrying -p actions -j 4
env:
DIR: "dir%20with unusual\"chars 'åß∂ƒ©∆¬…`"
DIR: dir%20with $unusual"chars?'åß∂ƒ©∆¬…`