Skip to content

net: fix family autoselection SSL connection handling #48189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShogunPanda wants to merge 2 commits into from
Closed

net: fix family autoselection SSL connection handling #48189

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e5e6ce6
net: fix family autoselection SSL connection handling
ShogunPanda May 26, 2023
5150216
net: move test to right location
ShogunPanda May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
net: move test to right location
  • Loading branch information
@ShogunPanda
ShogunPanda committed May 29, 2023
commit 51502162193a0a2d1b1ac6fd0c4b0a0f54148716
3 changes: 2 additions & 1 deletion ...st-https-autoselectfamily-slow-timeout.js → ...st-https-autoselectfamily-slow-timeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
'use strict';

const common = require('../common');
const { addresses } = require('../common/internet');

if (!common.hasCrypto)
common.skip('missing crypto');
Expand All @@ -9,7 +10,7 @@ const assert = require('assert');
const { request } = require('https');

request(
'https://nodejs.org/en',
`https://${addresses.INET_HOST}/en`,
// Purposely set this to false because we want all connection but the last to fail
{ autoSelectFamily: true, autoSelectFamilyAttemptTimeout: 10 },
(res) => {
Expand Down
4 changes: 2 additions & 2 deletions test/parallel/test-http-remove-connection-header-persists-connection.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';
require('../common');
const common = require('../common');
const assert = require('assert');

const net = require('net');
Expand Down Expand Up @@ -52,7 +52,7 @@ function makeHttp10Request(cb) {

setTimeout(function() {
cb(socket);
}, 10);
}, common.platformTimeout(50));
});
}

Expand Down