Skip to content

test_runner: display dot report as wide as the terminal width #48038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 6 commits into from
May 23, 2023
Merged

test_runner: display dot report as wide as the terminal width #48038

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c324ad8
test_runner: display dot report as wide as the terminal width
rluvaton May 6, 2023
b47e380
test_runner: add test and fix error
rluvaton May 19, 2023
ae1906c
Update lib/internal/test_runner/reporter/dot.js
rluvaton May 19, 2023
b991fd2
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
rluvaton May 20, 2023
d38e661
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
rluvaton May 22, 2023
ef8cec7
Update test/fixtures/test-runner/output/dot_output_custom_columns.js
rluvaton May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: add test and fix error
  • Loading branch information
@rluvaton
rluvaton committed May 19, 2023
commit b47e380287e0179c57dfb4f5641b3b360ae7ba12
1 change: 1 addition & 0 deletions lib/internal/test_runner/reporter/dot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ module.exports = async function* dot(source) {

// Getting again in case the terminal was resized.
columns = getLineLength();
count = 0;
}
}
yield '\n';
Expand Down
13 changes: 11 additions & 2 deletions test/fixtures/test-runner/output/dot_output_custom_columns.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,16 @@ process.stdout.columns = 30;

require('../../../common');
Comment thread
rluvaton marked this conversation as resolved.
Outdated
const test = require('node:test');
const {setTimeout} = require('timers/promises');
Comment thread
rluvaton marked this conversation as resolved.
Outdated

for (let i = 0; i < 100; i++) {
test(i + ' example', () => {});
}
test(i + ' example', async () => {
if(i === 0) {
Comment thread
rluvaton marked this conversation as resolved.
Outdated
// So the reporter will run before all tests has started
await setTimeout(10);
}
// resize
if (i === 28)
process.stdout.columns = 41;
});
}
5 changes: 2 additions & 3 deletions test/fixtures/test-runner/output/dot_output_custom_columns.snapshot
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
..............................
..............................
..............................
..........
.........................................
.............................