Skip to content

node-api: add status napi_cannot_run_js #47986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gabrielschulhof wants to merge 9 commits into from
Closed

node-api: add status napi_cannot_run_js #47986

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
0e89301
node-api: add status napi_cannot_run_js
gabrielschulhof May 13, 2023
86277c9
doc: update doc/api/n-api.md
gabrielschulhof May 16, 2023
fa45e0a
Update test/node-api/test_cannot_run_js/test.js
gabrielschulhof May 18, 2023
95137f5
test: access global property to illicit error status
gabrielschulhof May 18, 2023
72980e2
heed the linter
gabrielschulhof May 18, 2023
d6f3232
test: address nit
gabrielschulhof May 19, 2023
d8bee9e
test: use variables instead of target_defaults
gabrielschulhof May 19, 2023
ab54044
test: explicitly copy dependency
gabrielschulhof May 19, 2023
128a6f8
test: create job dependency to copy the common file
gabrielschulhof May 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update test/node-api/test_cannot_run_js/test.js 
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
  • Loading branch information
@gabrielschulhof @legendecas
gabrielschulhof and legendecas authored May 18, 2023
commit fa45e0a184d331d7541af100ffcdad8a0dd56435
2 changes: 1 addition & 1 deletion test/node-api/test_cannot_run_js/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ const addon_v8 = require(`./build/${buildType}/test_pending_exception`);
const addon_new = require(`./build/${buildType}/test_cannot_run_js`);

function runTests(addon, isVersion8) {
addon.createRef(runTests);
addon.createRef(common.mustNotCall());
}

function runAllTests() {
Expand Down