Skip to content

src: split BlobSerializer/BlobDeserializer #47458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
joyeecheung wants to merge 3 commits into from
Closed

src: split BlobSerializer/BlobDeserializer #47458

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6ab64d
src: split BlobSerializer/BlobDeserializer
joyeecheung Apr 7, 2023
2d58ed5
fixup! src: split BlobSerializer/BlobDeserializer
joyeecheung Apr 7, 2023
3294e8e
fixup! fixup! src: split BlobSerializer/BlobDeserializer
joyeecheung Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! fixup! src: split BlobSerializer/BlobDeserializer
  • Loading branch information
@joyeecheung
joyeecheung committed Apr 24, 2023
commit 3294e8eb594d60a7e34eb8e0d05b5373a09f5cf3
13 changes: 7 additions & 6 deletions src/node_snapshotable.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,9 +139,9 @@ std::ostream& operator<<(std::ostream& output, const EnvSerializeInfo& i) {
return output;
}

class BlobSerializeDeserializer {
class BlobSerializerDeserializer {
public:
explicit BlobSerializeDeserializer(bool is_debug_v) : is_debug(is_debug_v) {}
explicit BlobSerializerDeserializer(bool is_debug_v) : is_debug(is_debug_v) {}

template <typename... Args>
void Debug(const char* format, Args&&... args) const {
Expand Down Expand Up @@ -190,10 +190,10 @@ class BlobSerializeDeserializer {
// Child classes are expected to implement T Read<T>() where
// !std::is_arithmetic_v<T> && !std::is_same_v<T, std::string>
template <typename Impl>
class BlobDeserializer : public BlobSerializeDeserializer {
class BlobDeserializer : public BlobSerializerDeserializer {
public:
explicit BlobDeserializer(bool is_debug_v, std::string_view s)
: BlobSerializeDeserializer(is_debug_v), sink(s) {}
: BlobSerializerDeserializer(is_debug_v), sink(s) {}
~BlobDeserializer() {}

size_t read_total = 0;
Expand Down Expand Up @@ -329,9 +329,10 @@ class BlobDeserializer : public BlobSerializeDeserializer {
// Child classes are expected to implement size_t Write<T>(const T&) where
// !std::is_arithmetic_v<T> && !std::is_same_v<T, std::string>
template <typename Impl>
class BlobSerializer : public BlobSerializeDeserializer {
class BlobSerializer : public BlobSerializerDeserializer {
public:
explicit BlobSerializer(bool is_debug_v) : BlobSerializeDeserializer(is_debug_v) {
explicit BlobSerializer(bool is_debug_v)
: BlobSerializerDeserializer(is_debug_v) {
// Currently the snapshot blob built with an empty script is around 4MB.
// So use that as the default sink size.
sink.reserve(4 * 1024 * 1024);
Expand Down