Skip to content

src,http2: ensure cleanup if a frame is not sent #47244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Mar 30, 2023
Merged

src,http2: ensure cleanup if a frame is not sent #47244

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c680873
src,http2: ensure cleanup if a frame is not sent
ywave620 Mar 24, 2023
0e23ce1
src,http2: ensure cleanup if a frame is not sent
ywave620 Mar 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
src,http2: ensure cleanup if a frame is not sent 
Add test
  • Loading branch information
@ywave620
ywave620 committed Mar 24, 2023
commit 0e23ce177a0ec915bb62796c834b14778f692260
38 changes: 38 additions & 0 deletions test/parallel/test-h2-large-header-cause-client-to-hangup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
'use strict';

const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');
const http2 = require('http2');
const assert = require('assert');
const {
DEFAULT_SETTINGS_MAX_HEADER_LIST_SIZE,
NGHTTP2_CANCEL,
} = http2.constants;

const headerSize = DEFAULT_SETTINGS_MAX_HEADER_LIST_SIZE;
const timeout = common.platformTimeout(2_000);
const timer = setTimeout(() => assert.fail(`http2 client timedout
when server can not manage to send a header of size ${headerSize}`), timeout);

const server = http2.createServer((req, res) => {
res.setHeader('foobar', 'a'.repeat(DEFAULT_SETTINGS_MAX_HEADER_LIST_SIZE));
res.end();
});

server.listen(0, common.mustCall(() => {
const clientSession = http2.connect(`http://localhost:${server.address().port}`);
clientSession.on('close', common.mustCall());
clientSession.on('remoteSettings', send);

function send() {
const stream = clientSession.request({ ':path': '/' });
stream.on('close', common.mustCall(() => {
assert.strictEqual(stream.rstCode, NGHTTP2_CANCEL);
clearTimeout(timer);
server.close();
}));

stream.end();
}
}));