Skip to content

test_runner: expose reporter for use in run api #47238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Mar 28, 2023
Merged

test_runner: expose reporter for use in run api #47238

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3db2b52
test_runner: expose reporter for use in run api
atlowChemi Mar 23, 2023
0e16ae4
test_runner: CR - fix lint error & cleaner UT
atlowChemi Mar 24, 2023
7d1ba82
test_runner: fix lint error
atlowChemi Mar 24, 2023
16edd36
test_runner: CR add UT & lazy require
atlowChemi Mar 25, 2023
6f8b4ae
test_runner: CR cleanup
atlowChemi Mar 25, 2023
58a5989
fix test
atlowChemi Mar 26, 2023
b123070
cr proto:null
atlowChemi Mar 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test_runner: CR - fix lint error & cleaner UT
  • Loading branch information
@atlowChemi
atlowChemi committed Mar 24, 2023
commit 0e16ae4416dec767b610b980bbec697e9820b360
1 change: 1 addition & 0 deletions doc/api/test.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -751,6 +751,7 @@ added:

```mjs
import { tap } from 'node:test/reporters';
Comment thread
aduh95 marked this conversation as resolved.
import process from 'node:process';

run({ files: [path.resolve('./tests/test.js')] })
.compose(tap)
Expand Down
22 changes: 6 additions & 16 deletions test/parallel/test-runner-run.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,21 +68,11 @@ describe('require(\'node:test\').run', { concurrency: true }, () => {
}));
});

it('should be piped with dot', (ctx, done) => {
const written = [];
const writer = new Writable();
writer._write = function(chunk, encoding, cb) {
written.push(chunk.toString());
process.nextTick(cb);
};
function finish() {
assert.deepStrictEqual(written, [
'.',
'\n',
]);
done();
}
writer.on('finish', finish);
run({ files: [join(testFixtures, 'test/random.cjs')] }).compose(dot).pipe(writer);
it('should be piped with dot', async () => {
const result = await run({ files: [join(testFixtures, 'test/random.cjs')] }).compose(dot).toArray();
assert.deepStrictEqual(result, [
'.',
'\n',
]);
});
});