Skip to content

create vee-eight-4.9 branch #4722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
targos merged 9 commits into from
Feb 8, 2016
Merged

create vee-eight-4.9 branch #4722

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fdadc02
deps: upgrade to V8 4.9.385.18
ofrobots Jan 24, 2016
c0e11d8
deps: edit v8 gitignore to allow trace_event copy
ofrobots Jan 15, 2016
4b65870
deps: add V8 DEP trace_event
ofrobots Jan 15, 2016
c51d488
test: fix tests after V8 upgrade
targos Jan 22, 2016
9796b0c
test: fix proxy tab-completion test
ofrobots Jan 24, 2016
4c1433d
lib: wrap tick_processor scripts in IIFE
ofrobots Jan 24, 2016
01de50d
src: fix String::NewFromOneByte deprecation warnings
targos Jan 22, 2016
4a341b0
src: fix TryCatch deprecation warnings
targos Jan 26, 2016
e4ad3ab
src: fix NewInstance deprecation warnings
targos Jan 26, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: fix String::NewFromOneByte deprecation warnings 
PR-URL: #4722
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
  • Loading branch information
@targos
targos committed Feb 8, 2016
commit 01de50da3d95c4cde637b80aa8f2a9f60702611b
12 changes: 6 additions & 6 deletions src/util-inl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,26 +157,26 @@ inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
int length) {
return v8::String::NewFromOneByte(isolate,
reinterpret_cast<const uint8_t*>(data),
v8::String::kNormalString,
length);
v8::NewStringType::kNormal,
length).ToLocalChecked();
}

inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
const signed char* data,
int length) {
return v8::String::NewFromOneByte(isolate,
reinterpret_cast<const uint8_t*>(data),
v8::String::kNormalString,
length);
v8::NewStringType::kNormal,
length).ToLocalChecked();
}

inline v8::Local<v8::String> OneByteString(v8::Isolate* isolate,
const unsigned char* data,
int length) {
return v8::String::NewFromOneByte(isolate,
reinterpret_cast<const uint8_t*>(data),
v8::String::kNormalString,
length);
v8::NewStringType::kNormal,
length).ToLocalChecked();
}

template <typename TypeName>
Expand Down