Skip to content

wasi: add support for version when creating WASI #46469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mhdawson wants to merge 12 commits into from
Closed

wasi: add support for version when creating WASI #46469

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
97ef606
wasi: add support for version when creating WASI
mhdawson Jan 31, 2023
53c7fa1
squash: add pr-url for doc section
mhdawson Feb 1, 2023
1397b38
Update lib/wasi.js
mhdawson Feb 3, 2023
954a984
Update doc/api/wasi.md
mhdawson Feb 3, 2023
848373c
Update doc/api/wasi.md
mhdawson Feb 3, 2023
388dc3f
Update doc/api/wasi.md
mhdawson Feb 3, 2023
3cab1f5
squash: address comments
mhdawson Feb 3, 2023
61dca0b
squash: address comments
mhdawson Feb 3, 2023
9f07256
squash: address comments
mhdawson Feb 6, 2023
fc34053
squash: address comments
mhdawson Feb 6, 2023
ad25e59
squash: address comments
mhdawson Feb 6, 2023
9107570
squash: remove test code related to unstable
mhdawson Feb 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
squash: address comments 
Signed-off-by: Michael Dawson <mdawson@devrus.com>
  • Loading branch information
@mhdawson
mhdawson committed Feb 6, 2023
commit ad25e59b1d7cb419d6fda4439040288830b86bb7
6 changes: 4 additions & 2 deletions test/wasi/test-wasi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ if (process.argv[2] === 'wasi-child-default') {
wasi.start(instance);
})().then(common.mustCall());
} else if (process.argv[2] === 'wasi-child-preview1') {
// Test version set to wasi_snapshot_preview1
// Test version set to preview1
const assert = require('assert');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
Expand Down Expand Up @@ -69,7 +69,7 @@ if (process.argv[2] === 'wasi-child-default') {
wasiPreview1.start(instancePreview1);
})().then(common.mustCall());
} else if (process.argv[2] === 'wasi-child-unstable') {
// Test version set to wasi_snapshot_preview1
// Test version set to unstable
const assert = require('assert');
const fixtures = require('../common/fixtures');
const tmpdir = require('../common/tmpdir');
Expand Down Expand Up @@ -140,6 +140,8 @@ if (process.argv[2] === 'wasi-child-default') {
innerRunWASI(options, ['--no-turbo-fast-api-calls']);
innerRunWASI(options, ['--turbo-fast-api-calls']);
innerRunWASI(options, ['--turbo-fast-api-calls'], 'preview1');
// TODO(mhdawson) do we need testing for unstable?
// innerRunWASI(options, ['--turbo-fast-api-calls'], 'unstable');
}

runWASI({ test: 'cant_dotdot' });
Expand Down