Skip to content

net: check autoSelectFamilyAttemptTimeout is positive #45740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
deokjinkim wants to merge 3 commits into from
Closed

net: check autoSelectFamilyAttemptTimeout is positive #45740

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c16edf4
net: check `autoSelectFamilyAttemptTimeout` is positive
deokjinkim Dec 5, 2022
9e89229
add test case
deokjinkim Dec 5, 2022
017002d
use hard-coded negative integer and zero for test
deokjinkim Dec 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add test case
  • Loading branch information
@deokjinkim
deokjinkim committed Dec 5, 2022
commit 9e892293eb17223ae3d05e488219ecb909509af2
14 changes: 14 additions & 0 deletions test/parallel/test-net-socket-connect-invalid-autoselectfamilyattempttimeout.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const net = require('net');

const autoSelectFamilyAttemptTimeout = common.platformTimeout(-10);

assert.throws(() => {
net.connect({
port: 8080,
autoSelectFamily: true,
autoSelectFamilyAttemptTimeout,
});
}, { code: 'ERR_OUT_OF_RANGE' });
Comment thread
tniessen marked this conversation as resolved.
Outdated