Skip to content

http: Make OutgoingMessage more streamlike #45672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 10 commits into from
Dec 2, 2022
Merged

http: Make OutgoingMessage more streamlike #45672

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1047db4
http: Make OutgoingMessage more streamlike
ronag Nov 29, 2022
7813900
fixup
ronag Nov 29, 2022
8d247a5
fixup
ronag Nov 29, 2022
e0a4a31
fixuP
ronag Nov 29, 2022
c9a76ba
fixuP
ronag Nov 29, 2022
2a412af
fixup: tests
ronag Nov 29, 2022
3b3fbb5
fiuxp
ronag Nov 29, 2022
25d952b
fiuxp
ronag Nov 29, 2022
305ade0
Apply suggestions from code review
ronag Nov 30, 2022
fd82016
fixup
ronag Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: tests
  • Loading branch information
@ronag
ronag committed Nov 29, 2022
commit 2a412af52a034f6dc1004d4b21219cc671798552
9 changes: 8 additions & 1 deletion test/parallel/test-http-client-incomingmessage-destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,13 @@ server.listen(0, () => {
get({
port: server.address().port
}, common.mustCall((res) => {
res.destroy(new Error('Destroy test'));
const err = new Error('Destroy test')
Comment thread
ronag marked this conversation as resolved.
Outdated
assert.strictEqual(res.errored, null);
res.destroy(err);
assert.strictEqual(res.closed, false);
assert.strictEqual(res.errored, err);
res.on('close', () => {
assert.strictEqual(res.closed, true);
})
Comment thread
ronag marked this conversation as resolved.
Outdated
}));
});