Skip to content

Make clientError overridable #4557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
indutny wants to merge 5 commits into from
Closed

Make clientError overridable #4557

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0f65247
tls: rename `clientError` to `tlsClientError`
indutny Jan 6, 2016
9fc35f4
http: overridable `clientError`
indutny Jan 6, 2016
3967df7
doc: http fixes
indutny Jan 6, 2016
5515479
http: test and fixes
indutny Jan 7, 2016
2ba3898
https: fixes
indutny Jan 7, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: http fixes
  • Loading branch information
@indutny
indutny committed Jan 6, 2016
commit 3967df7915e4514c25a95cdd6565a9175ae7985e
7 changes: 4 additions & 3 deletions doc/api/http.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,10 +421,11 @@ not be emitted.
`function (exception, socket) { }`

If a client connection emits an `'error'` event, it will be forwarded here.
Listener of this event is responsible for destroying socket, and, for example,
can do it it gracefully by sending 400 HTTP response.
Listener of this event is responsible for closing/destroying the underlying
socket. For example, one may wish to more gracefully close the socket with an
HTTP '400 Bad Request' response instead of abruptly severing the connection.

Default behavior is destroy socket immediately.
Default behavior is to destroy the socket immediately on malformed request.

`socket` is the [`net.Socket`][] object that the error originated from.

Expand Down