Skip to content

deps: V8: cherry-pick 9df5ef70ff18 #45474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Nov 18, 2022
Merged

deps: V8: cherry-pick 9df5ef70ff18 #45474

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1d63fa
deps: V8: cherry-pick 9df5ef70ff18
anonrig Nov 15, 2022
4562373
deps: V8: remove detach check
anonrig Nov 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps: V8: remove detach check
  • Loading branch information
@anonrig
anonrig committed Nov 16, 2022
commit 4562373508e7453bac0121cfca5c10ce0d18f6e0
2 changes: 1 addition & 1 deletion deps/v8/test/cctest/test-api-array-buffer.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,7 @@ THREADED_TEST(ArrayBuffer_WasDetached) {
Local<v8::ArrayBuffer> ab = v8::ArrayBuffer::New(isolate, 0);
CHECK(!ab->WasDetached());

ab->Detach(v8::Local<v8::Value>()).Check();
ab->Detach();
CHECK(ab->WasDetached());
}

Expand Down