Skip to content

test_runner: fix afterEach not running on test failures #45204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Nov 7, 2022
Merged

test_runner: fix afterEach not running on test failures #45204

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
14af24b
test_runner: fix afterEach not running on test failures
MrJithil Oct 27, 2022
30268cd
fix
MoLow Nov 5, 2022
c17bb82
CR
MoLow Nov 5, 2022
a9defa0
CR
MoLow Nov 6, 2022
5880f19
CR
MoLow Nov 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
CR
  • Loading branch information
@MoLow
MoLow committed Nov 6, 2022
commit 5880f19d59b85c74945929c04954e6b6c770210a
6 changes: 2 additions & 4 deletions lib/internal/test_runner/test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,8 +528,7 @@ class Test extends AsyncResource {
await afterEach();
this.pass();
} catch (err) {
// eslint-disable-next-line no-empty
try { await afterEach(); } catch {}
try { await afterEach(); } catch { /* test is already failing, let's the error */ }
if (isTestFailureError(err)) {
if (err.failureType === kTestTimeoutFailure) {
this.cancel(err);
Expand Down Expand Up @@ -768,8 +767,7 @@ class Suite extends Test {

this.pass();
} catch (err) {
// eslint-disable-next-line no-empty
try { await afterEach(); } catch {}
try { await afterEach(); } catch { /* test is already failing, let's the error */ }
if (isTestFailureError(err)) {
this.fail(err);
} else {
Expand Down