Skip to content

build: add version info to timezone update PR #45021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Oct 18, 2022
Merged

build: add version info to timezone update PR #45021

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
build: add version info to timezone update PR 
Refs: #44950 (comment)
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
@RaisinTen
RaisinTen committed Oct 16, 2022
commit 7c3c886d136f2cabf5137bbfd19a16d5fa76c796
7 changes: 5 additions & 2 deletions .github/workflows/timezone-update.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ jobs:
persist-credentials: false
repository: unicode-org/icu-data

- name: Record new version
run: echo "new_version=$(ls icu-data/tzdata/icunew | tail -1)" >> $GITHUB_ENV

- run: ./tools/update-timezone.mjs

- name: Open Pull Request
Expand All @@ -49,7 +52,7 @@ jobs:
console.log(process.versions.tz)
```
branch: actions/timezone-update
commit-message: 'deps: update timezone'
commit-message: 'deps: update timezone to ${{ env.new_version }}'
labels: dependencies
title: 'deps: update timezone'
title: 'deps: update timezone to ${{ env.new_version }}'
reviewers: \@nodejs/i18n-api