Skip to content

src: use a typed array internally for process._exiting #43883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 7 commits into from
Jul 31, 2022
Merged

src: use a typed array internally for process._exiting #43883

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
728c0de
src: use a typed array internally for process._exiting
RaisinTen Jul 17, 2022
99f6403
Update src/node_process_object.cc
RaisinTen Jul 18, 2022
20ad6c1
fixup! Update src/node_process_object.cc
RaisinTen Jul 18, 2022
7d3b32e
src: use a private symbol instead of a string key
RaisinTen Jul 22, 2022
1058776
fixup! clang-format fix
RaisinTen Jul 22, 2022
18b29f2
fixup! stop calling getHiddenValue() every time process._exiting is a…
RaisinTen Jul 24, 2022
a9e68be
fixup! fixup! stop calling getHiddenValue() every time process._exiti…
RaisinTen Jul 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup! Update src/node_process_object.cc 
Signed-off-by: Darshan Sen <raisinten@gmail.com>
  • Loading branch information
@RaisinTen
RaisinTen committed Jul 18, 2022
commit 20ad6c1152284dded8db08bc09c74a42f86aec1c
3 changes: 2 additions & 1 deletion src/node_process_object.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,8 @@ MaybeLocal<Object> CreateProcessObject(Environment* env) {
// process._exitingAliasedUint32Array
Local<String> exiting_string =
FIXED_ONE_BYTE_STRING(env->isolate(), "_exitingAliasedUint32Array");
Comment thread
RaisinTen marked this conversation as resolved.
Outdated
if (process->Set(context, exiting_string, env->exiting().GetJSArray()).IsNothing()) {
if (process->Set(context, exiting_string, env->exiting().GetJSArray())
.IsNothing()) {
return {};
}

Expand Down