Skip to content

test_runner: wait for stderr and stdout to complete #43666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jul 8, 2022
Merged

test_runner: wait for stderr and stdout to complete #43666

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b82a40f
test_runner: wait for stderr and stdout to complete
MoLow Jul 3, 2022
e48d3ec
Apply suggestions from code review
MoLow Jul 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Apply suggestions from code review 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@MoLow @aduh95
MoLow and aduh95 authored Jul 4, 2022
commit e48d3eccbd6c58e30343fe9766bf9e700afb940b
3 changes: 2 additions & 1 deletion lib/internal/main/test_runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ const {
ArrayPrototypeSort,
Promise,
PromiseAll,
Comment thread
MoLow marked this conversation as resolved.
SafeArrayIterator,
SafeSet,
} = primordials;
const {
Expand Down Expand Up @@ -131,7 +132,7 @@ function runTestFile(path) {
child.once('exit', async (code, signal) => {
if (code !== 0 || signal !== null) {
if (!err) {
await PromiseAll([finished(child.stderr), finished(child.stdout)]);
await PromiseAll(new SafeArrayIterator([finished(child.stderr), finished(child.stdout)]));
err = new ERR_TEST_FAILURE('test failed', kSubtestsFailed);
err.exitCode = code;
err.signal = signal;
Expand Down