Skip to content

stream: pass error on legacy destroy #43519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 28, 2022
Merged

stream: pass error on legacy destroy #43519

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10be672
stream: pass error on legacy destroy
greguz Jun 21, 2022
fa5c436
stream: test legacy error event
greguz Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
stream: pass error on legacy destroy
  • Loading branch information
@greguz
greguz committed Jun 21, 2022
commit 10be672884552d90d81d21321b09c47bf07729aa
2 changes: 1 addition & 1 deletion lib/internal/streams/destroy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ function destroyer(stream, err) {
// TODO: Don't lose err?
stream.close();
} else if (err) {
process.nextTick(emitErrorCloseLegacy, stream);
process.nextTick(emitErrorCloseLegacy, stream, err);
} else {
process.nextTick(emitCloseLegacy, stream);
}
Expand Down