Skip to content

test: improve coverage for load hooks #43374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Jun 18, 2022
Merged

test: improve coverage for load hooks #43374

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3789b5
test: improve coverage for load hooks
aduh95 Jun 11, 2022
3e399b2
fixup! test: improve coverage for load hooks
aduh95 Jun 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! test: improve coverage for load hooks
  • Loading branch information
@aduh95
aduh95 committed Jun 17, 2022
commit 3e399b2fa1b2ce5d48237e91cf18b6d504157647
4 changes: 2 additions & 2 deletions test/es-module/test-esm-loader-thenable.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ import { execPath } from 'process';
child.on('close', mustCall((code, _signal) => {
notStrictEqual(code, 0);

match(stderr, /\sError: must crash the process\n/);
match(stderr, /\sError: must crash the process\r?\n/);

ok(!stderr.includes('must not call'));
}));
Expand All @@ -58,7 +58,7 @@ import { execPath } from 'process';
child.on('close', mustCall((code, _signal) => {
notStrictEqual(code, 0);

match(stderr, /\sundefined\n/);
match(stderr, /\sundefined\r?\n/);

ok(!stderr.includes('must not call'));
}));
Expand Down