Skip to content

test: reduce flakiness of test-fs-read-position-validation.mjs #42999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 9 commits into from
May 15, 2022
+107 −66
Merged

test: reduce flakiness of test-fs-read-position-validation.mjs #42999

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fe48cc5
test: reduce flakiness of `test-fs-read-position-validation.mjs`
LiviaMedeiros May 6, 2022
21a0db5
squash: adjust promisification
LiviaMedeiros May 7, 2022
e2c07c9
squash: fix typo
LiviaMedeiros May 7, 2022
d9a88ba
squash: the actual fix: do not close file too early
LiviaMedeiros May 7, 2022
90e5cd7
squash: refactor callbacks, add test for buffer[, options]
LiviaMedeiros May 7, 2022
45b3626
squash: refactor promisification
LiviaMedeiros May 7, 2022
c85e84d
squash: add explicit async
LiviaMedeiros May 7, 2022
f114cbb
squash: reject on errors
LiviaMedeiros May 7, 2022
11a5b35
squash: fix race condition on closing fd
LiviaMedeiros May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
squash: fix race condition on closing fd 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@LiviaMedeiros @aduh95
LiviaMedeiros and aduh95 committed May 15, 2022
commit 11a5b35bc63893bede0dc0fcd5de609a19c822d6
3 changes: 2 additions & 1 deletion test/parallel/test-fs-read-position-validation.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ async function testValid(position, allowedErrors = []) {
const handler = common.mustCall((err) => {
callCount--;
if (err && !allowedErrors.includes(err.code)) {
fs.close(fd, common.mustSucceed(() => reject(err)));
fs.close(fd, common.mustSucceed());
reject(err);
} else if (callCount === 0) {
fs.close(fd, common.mustSucceed(resolve));
}
Expand Down