Skip to content

os: avoid unnecessary usage of var #42563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 1 commit into from
Apr 3, 2022
Merged

os: avoid unnecessary usage of var #42563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
os: avoid unnecessary usage of var 
The `var` keyword is known to be problematic and is not needed here,
so better to use the `let` keyword for variable declarations.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva committed Apr 1, 2022
commit 01921f1114f1f67248a6228da326c003d5f3bffd
6 changes: 3 additions & 3 deletions lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ platform[SymbolToPrimitive] = () => process.platform;
* @returns {string}
*/
function tmpdir() {
var path;
let path;
if (isWindows) {
path = process.env.TEMP ||
process.env.TMP ||
Expand Down Expand Up @@ -223,7 +223,7 @@ function getCIDR(address, netmask, family) {
}

const parts = StringPrototypeSplit(netmask, split);
for (var i = 0; i < parts.length; i++) {
for (let i = 0; i < parts.length; i++) {
if (parts[i] !== '') {
const binary = NumberParseInt(parts[i], range);
const tmp = countBinaryOnes(binary);
Expand Down Expand Up @@ -261,7 +261,7 @@ function networkInterfaces() {

if (data === undefined)
return result;
for (var i = 0; i < data.length; i += 7) {
for (let i = 0; i < data.length; i += 7) {
const name = data[i];
const entry = {
address: data[i + 1],
Expand Down