Skip to content

doc: document breaking change in http.IncomingMessage 'close' event #42521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aduh95 merged 3 commits into from
Apr 1, 2022
Merged

doc: document breaking change in http.IncomingMessage 'close' event #42521

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e898f72
http: document breaking change
ShogunPanda Mar 30, 2022
ef36972
doc: Lint changelog
ShogunPanda Mar 31, 2022
b4f1bb1
doc: respect alphabetical ordering in changelog
ShogunPanda Apr 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
http: document breaking change
  • Loading branch information
@ShogunPanda
ShogunPanda committed Mar 30, 2022
commit e898f726176d8cb060bd493f12b5e0cc3066285c
7 changes: 6 additions & 1 deletion doc/api/http.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2112,9 +2112,14 @@ Emitted when the request has been aborted.

<!-- YAML
added: v0.4.2
changes:
- version: v16.0.0
pr-url: https://github.com/nodejs/node/pull/33035
description: The close event is now emitted when the request has been completed and not when the
underlying socket is closed.
-->

Indicates that the underlying connection was closed.
Emitted when the request has been completed.

### `message.aborted`

Expand Down
1 change: 1 addition & 0 deletions doc/changelogs/CHANGELOG_V16.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2443,6 +2443,7 @@ Contributed by Michaël Zasso - [#37587](https://github.com/nodejs/node/pull/375
* **(SEMVER-MINOR)** **assert**: graduate assert.match and assert.doesNotMatch (James M Snell) [#38111](https://github.com/nodejs/node/pull/38111)
* **(SEMVER-MAJOR)** **buffer**: expose btoa and atob as globals (James M Snell) [#37786](https://github.com/nodejs/node/pull/37786)
* **(SEMVER-MAJOR)** **deps**: bump minimum ICU version to 68 (Michaël Zasso) [#37330](https://github.com/nodejs/node/pull/37330)
* **(SEMVER-MAJOR)** **http**: use autoDestroy: true in incoming message (Daniele Belardi) [#33035](https://github.com/nodejs/node/pull/33035)
Comment thread
ShogunPanda marked this conversation as resolved.
Resolved
* **deps**: update ICU to 69.1 (Michaël Zasso) [#38178](https://github.com/nodejs/node/pull/38178)
* **deps**: update llhttp to 6.0.0 (Fedor Indutny) [#38277](https://github.com/nodejs/node/pull/38277)
* **deps**: upgrade npm to 7.10.0 (Ruy Adorno) [#38254](https://github.com/nodejs/node/pull/38254)
Expand Down