Skip to content

test: add --trace-gc flag test #42471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 5 commits into from
Mar 28, 2022
Merged

test: add --trace-gc flag test #42471

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1442662
test: add trace-gc flag test
tony-go Mar 25, 2022
edccf35
test: add line break in gc fixture
tony-go Mar 26, 2022
85d8e3b
doc: nitpick fix
tony-go Mar 28, 2022
7442e90
test: use assert.match instead of assert.ok
tony-go Mar 28, 2022
2f7fb1a
test: delete Regex call and trim string output
tony-go Mar 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions test/fixtures/gc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
let arr = new Array(300_000).fill('a');

for (let index = 0; index < arr.length; index++) {
arr[index] = Math.random();
}

arr = [];
// .gc() is called to generate a Mark-sweep event
global.gc();
Comment thread
tony-go marked this conversation as resolved.
Resolved
41 changes: 41 additions & 0 deletions test/v8-updates/test-trace-gc-flag.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
'use strict';

// This test verifies that `--trace-gc` flag is well integrated.
// We'll check here, that the console outputs gc events properly
Comment thread
tony-go marked this conversation as resolved.
Resolved
require('../common');

const assert = require('assert');
const { spawnSync } = require('child_process');

const fixtures = require('../common/fixtures');

{
const childProcess = spawnSync(process.execPath, [
'--trace-gc',
'--expose-gc',
fixtures.path('gc.js'),
]);
const output = childProcess.stdout.toString();
const lines = splitByLine(output);

const scavengeRegex = /\bScavenge\b/;
const expectedOutput = [
scavengeRegex,
scavengeRegex,
scavengeRegex,
scavengeRegex,
/\bMark-sweep\b/,
];
lines.forEach((line, index) => {
const isMatched = line.match(expectedOutput[index]);
Comment thread
tony-go marked this conversation as resolved.
Resolved
assert.ok(isMatched);
});
}

/**
* HELPERS
*/

function splitByLine(str) {
return str.split(/\n/);
}