Skip to content

stream: add more filter tests #41936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjamingr wants to merge 3 commits into from
Closed

stream: add more filter tests #41936

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b3ccbce
stream: add more filter tests
benjamingr Feb 11, 2022
6d10c20
fixup!
benjamingr Feb 11, 2022
3e39e50
fixup! remove timeout from test
benjamingr Feb 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! remove timeout from test
  • Loading branch information
@benjamingr
benjamingr committed Feb 14, 2022
commit 3e39e508829321325403ebf31e2e4b7ff0692174
3 changes: 2 additions & 1 deletion test/parallel/test-stream-filter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ const {
Readable,
} = require('stream');
const assert = require('assert');
const { once } = require('events');
const { setTimeout } = require('timers/promises');

{
Expand Down Expand Up @@ -119,7 +120,7 @@ const { setTimeout } = require('timers/promises');
let calls = 0;
const stream = Readable.from([1, 2, 3, 4]).filter(async (_, { signal }) => {
calls++;
await setTimeout(100, { signal });
await once(signal, 'abort');
}, { signal: ac.signal, concurrency: 2 });
// pump
assert.rejects(async () => {
Expand Down