Skip to content

doc: add fspromises mkdir example #40843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 8 commits into from
Jun 12, 2022
Merged

doc: add fspromises mkdir example #40843

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7a4a320
doc: add fspromises mkdir example
bnb Nov 17, 2021
9fcb48e
doc: fspromises mkdir example cleanup
bnb Nov 18, 2021
38ed2f2
doc: update fs mkdir examples for clarity
bnb Jun 11, 2022
90e60a2
doc: use node prefix in fs/promises mkdir examples
bnb Jun 11, 2022
d63bc20
doc: make fs/promises mkdir cjs example work
bnb Jun 11, 2022
f0c22f3
doc: remove try/catch in fs/promises mkdir example
bnb Jun 11, 2022
7bc43d8
doc: use prefix in esm fs/promises mkdir example
bnb Jun 11, 2022
775fb38
doc: add missing semicolon in fs.md
bnb Jun 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: fspromises mkdir example cleanup 
Signed-off-by: Tierney Cyren <hello@bnb.im>
  • Loading branch information
@bnb
bnb committed Nov 18, 2021
commit 9fcb48eb0364a32eeccf9397f90cbdb97218f8a1
20 changes: 13 additions & 7 deletions doc/api/fs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1014,7 +1014,7 @@ try {
const path = new URL('./test/project', import.meta.url);
Comment thread
bnb marked this conversation as resolved.
Outdated
const createDir = await mkdir(path, { recursive: true });

console.log (`created ${createDir}`);
console.log(`created ${createDir}`);
} catch (err) {
console.error(err.message);
}
Expand All @@ -1024,16 +1024,22 @@ try {
const { mkdir } = require('fs/promises');
const { resolve } = require('path');

async function makeDirectory () {
const path = resolve('./test/project/lol/hi')
const dirCreation = await mkdir(path, { recursive: true });

console.log(dirCreation)
return dirCreation;
async function makeDirectory() {
try {
const path = resolve('./test/project/lol/hi');
Comment thread
bnb marked this conversation as resolved.
Outdated
const dirCreation = await mkdir(path, { recursive: true });

console.log(dirCreation);
return dirCreation;
} catch (err) {
console.error(err.message);
}

}

makeDirectory();

@aduh95 aduh95 Jun 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: instead of a try/catch, I would put a .catch(console.error): calling an async function without awaiting it or having a catch handler should be frowned upon imho.

@bnb bnb Jun 11, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would you want me to move the MJS example to be a function and do the same, or should that continue using top-level await in a try/catch?

```

### `fsPromises.mkdtemp(prefix[, options])`

<!-- YAML
Expand Down