Skip to content

lib: simplify validators #39753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 3 commits into from
Closed

lib: simplify validators #39753

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
310ed47
lib: simplify validators
VoltrexKeyva Aug 12, 2021
baa5a2f
dgram: use simplified validator
VoltrexKeyva Aug 12, 2021
68e0101
test: use simplfied validator
VoltrexKeyva Aug 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
dgram: use simplified validator 
The `dgram` lib module should use the simplified `validatePort()`
validator.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva committed Aug 13, 2021
commit baa5a2f049245f6f463284ac8447587357cca8d0
4 changes: 2 additions & 2 deletions lib/dgram.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ Socket.prototype.bind = function(port_, address_ /* , callback */) {
};

Socket.prototype.connect = function(port, address, callback) {
port = validatePort(port, 'Port', { allowZero: false });
port = validatePort(port, 'Port', false);
if (typeof address === 'function') {
callback = address;
address = '';
Expand Down Expand Up @@ -626,7 +626,7 @@ Socket.prototype.send = function(buffer,
}

if (!connected)
port = validatePort(port, 'Port', { allowZero: false });
port = validatePort(port, 'Port', false);

// Normalize callback so it's either a function or undefined but not anything
// else.
Expand Down