Skip to content

[v14.x backport] buffer: introduce Blob #39704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 10 commits into from
Closed

[v14.x backport] buffer: introduce Blob #39704

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
deb8512
buffer: introduce Blob
jasnell Aug 8, 2021
bdff82f
test: add wpt tests for Blob
targos Jan 6, 2021
71ccdf3
util: add internal createDeferredPromise()
cjihrig Jan 27, 2021
bb0c918
buffer: add @@toStringTag to Blob
cjihrig Feb 12, 2021
2ad19c1
buffer: make Blob's slice method more spec-compliant
targos Feb 13, 2021
60a4de6
buffer: make Blob's constructor more spec-compliant
targos Feb 13, 2021
2dd9467
src: use BaseObject::kInteralFieldCount in Blob
joyeecheung Jan 19, 2021
add1067
buffer: avoid creating the backing store in the thread
jasnell Jan 24, 2021
5eaf696
src: remove more extra semis from member fns
codebytere May 20, 2021
9a9f207
test: increase coverage for Blob
Lxxyx May 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
src: use BaseObject::kInteralFieldCount in Blob 
Instead of hard-coding the field count.

PR-URL: #36991
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
  • Loading branch information
@joyeecheung @targos
joyeecheung authored and targos committed Aug 13, 2021
commit 2dd94671e4ead9cf0734ca25e7b7dc3df4217e72
3 changes: 2 additions & 1 deletion src/node_blob.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ Local<FunctionTemplate> Blob::GetConstructorTemplate(Environment* env) {
Local<FunctionTemplate> tmpl = env->blob_constructor_template();
if (tmpl.IsEmpty()) {
tmpl = FunctionTemplate::New(env->isolate());
tmpl->InstanceTemplate()->SetInternalFieldCount(1);
tmpl->InstanceTemplate()->SetInternalFieldCount(
BaseObject::kInternalFieldCount);
tmpl->Inherit(BaseObject::GetConstructorTemplate(env));
tmpl->SetClassName(
FIXED_ONE_BYTE_STRING(env->isolate(), "Blob"));
Expand Down