Skip to content

lib: cleanup validation #39652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 1 commit into from
+3 −10
Closed

lib: cleanup validation #39652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: cleanup validation 
Used the `validateInteger()` validator to cleanup validation and keep
consistency.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva committed Aug 3, 2021
commit d453331889c9986e2eeeeac5a0f2c17f47153b7a
13 changes: 3 additions & 10 deletions lib/internal/tty.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ const {
StringPrototypeToLowerCase,
} = primordials;

const {
ERR_INVALID_ARG_TYPE,
ERR_OUT_OF_RANGE
} = require('internal/errors').codes;
const { validateInteger } = require('internal/validators');

let OSRelease;

Expand Down Expand Up @@ -221,13 +218,9 @@ function hasColors(count, env) {
env = count;
count = 16;
} else {
if (typeof count !== 'number') {
throw new ERR_INVALID_ARG_TYPE('count', 'number', count);
}
if (count < 2) {
throw new ERR_OUT_OF_RANGE('count', '>= 2', count);
}
validateInteger(count, 'count', 2);
}

return count <= 2 ** getColorDepth(env);
}

Expand Down