Skip to content

[v16.x-backport] deps: update V8 to 9.2 #39470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 34 commits into from
Closed

[v16.x-backport] deps: update V8 to 9.2 #39470

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
638a5c7
deps: update V8 to 9.2.230.21
targos Jul 20, 2021
4c23bab
build: reset embedder string to "-node.0"
targos Jul 20, 2021
7d8a1c7
deps: V8: un-cherry-pick bd019bd
refack Mar 27, 2019
6ed4a86
deps: V8: patch register-arm64.h
refack May 22, 2019
543332a
deps: V8: forward declaration of `Rtl*FunctionTable`
refack May 22, 2019
5a08ec7
deps: make v8.h compatible with VS2015
joaocgreis Nov 1, 2019
f025f24
deps: fix V8 build issue with inline methods
gengjiawen Oct 14, 2020
87333cf
deps: silence irrelevant V8 warnings
targos Jan 30, 2021
b91e49c
deps: silence irrelevant V8 warning
targos May 1, 2021
2c8be6d
tools: update V8 gypfiles for 9.2
targos Apr 11, 2021
512659e
src: use non-deprecated Symbol::Description
targos Apr 14, 2021
5a650f8
src: stop using deprecated v8::ApiObject
targos Apr 26, 2021
9a78845
test: update trace events test expectations
targos Apr 21, 2021
7aaa214
test: remove test-debug-args
targos Apr 26, 2021
dbe4a0b
test: ensure microtask queues are not automatically drained
jeisinger Apr 29, 2021
62349be
deps: V8: cherry-pick 3d24b3ab8af0
targos Jun 10, 2021
8ec3459
deps: V8: backport 71e8f8bb3c26
targos Jun 16, 2021
d518175
deps: V8: cherry-pick 986299250e6d
richardlau Jun 16, 2021
bc48c1e
deps: V8: cherry-pick a5cea1bfc38c
targos Jun 20, 2021
24078b2
deps: V8: cherry-pick 7ff6609a5385
targos Jun 20, 2021
7f7e8df
deps: V8: cherry-pick 53784bdb8f01
targos Jul 10, 2021
2cde0ab
deps: V8: cherry-pick 2b77ca200c56
targos Jul 10, 2021
fdaddab
deps: V8: cherry-pick 56fe020eec0c
targos Jul 10, 2021
dcb52a9
deps: V8: cherry-pick 3805a698f7b6
targos Jul 10, 2021
a47081b
deps: V8: cherry-pick 359d44df4cdd
targos Jul 10, 2021
bd01a54
deps: V8: backport 5c76da8ddcf8
targos Jul 10, 2021
3d4413b
tools: fetch googletest dependency for V8 CI
targos Jul 14, 2021
38c82dc
deps: make V8 9.2 abi-compatible with 9.0
targos Jul 20, 2021
2f4bb0e
deps: restore minimum ICU version to 68
targos Jul 20, 2021
0d09b3e
squash! deps: make V8 9.2 abi-compatible with 9.0
targos Jul 20, 2021
d06c730
squash! deps: make V8 9.2 abi-compatible with 9.0
targos Jul 20, 2021
6bb96dd
squash! deps: make V8 9.2 abi-compatible with 9.0
targos Jul 22, 2021
f9b7513
squash! deps: make V8 9.2 abi-compatible with 9.0
targos Jul 23, 2021
d171381
fixup! squash! deps: make V8 9.2 abi-compatible with 9.0
targos Jul 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
deps: V8: cherry-pick 3d24b3ab8af0 
Original commit message:

    ARM64: VRegister::from_code expected to be constexpr

    GCC build fails trying to use a non constexpr function from a
    constexpr function.

    ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h: In member function 'constexpr v8::internal::DoubleRegister v8::internal::wasm::LiftoffRegister::fp() const':
    ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-register.h:286:71: error: call to non-'constexpr' function 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)'
      286 |     return DoubleRegister::from_code(code_ - kAfterMaxLiftoffGpRegCode);
          |                                                                       ^
    In file included from ../chromium-92.0.4503.0/v8/src/codegen/register-arch.h:16,
                     from ../chromium-92.0.4503.0/v8/src/deoptimizer/translation-array.h:8,
                     from ../chromium-92.0.4503.0/v8/src/objects/code.h:10,
                     from ../chromium-92.0.4503.0/v8/src/codegen/reloc-info.h:10,
                     from ../chromium-92.0.4503.0/v8/src/codegen/assembler.h:47,
                     from ../chromium-92.0.4503.0/v8/src/codegen/assembler-arch.h:8,
                     from ../chromium-92.0.4503.0/v8/src/codegen/turbo-assembler.h:12,
                     from ../chromium-92.0.4503.0/v8/src/codegen/macro-assembler.h:8,
                     from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.h:13,
                     from ../chromium-92.0.4503.0/v8/src/wasm/baseline/liftoff-assembler.cc:5:
    ../chromium-92.0.4503.0/v8/src/codegen/arm64/register-arm64.h:416:20: note: 'static v8::internal::VRegister v8::internal::VRegister::from_code(int)' declared here
      416 |   static VRegister from_code(int code) {
          |                    ^~~~~~~~~

    Bug: chromium:819294
    Change-Id: Ia19ea90f3f666702d32c90e147af17dcda7e08a6
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2929805
    Reviewed-by: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: José Dapena Paz <jdapena@igalia.com>
    Cr-Commit-Position: refs/heads/master@{#74889}

Refs: v8/v8@3d24b3a

PR-URL: #38990
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
@targos
targos committed Jul 20, 2021
commit 62349bef3b4f2a624c48d8460c97ec5059ee608e
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.7',
'v8_embedder_string': '-node.8',

##### V8 defaults for Node.js #####

Expand Down
2 changes: 1 addition & 1 deletion deps/v8/src/codegen/arm64/register-arm64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,7 @@ class VRegister : public CPURegister {
static constexpr int kMaxNumRegisters = kNumberOfVRegisters;
STATIC_ASSERT(kMaxNumRegisters == kDoubleAfterLast);

static VRegister from_code(int code) {
static constexpr VRegister from_code(int code) {
// Always return a D register.
return VRegister::Create(code, kDRegSizeInBits);
}
Expand Down