Skip to content

Backport V8 fixes for WASM on ARM64 #39337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
targos wants to merge 7 commits into from
Closed

Backport V8 fixes for WASM on ARM64 #39337

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1e25816
deps: V8: cherry-pick cb4faa902e9f
targos Jul 10, 2021
bb076a3
deps: V8: cherry-pick 53784bdb8f01
targos Jul 10, 2021
9caa1bb
deps: V8: cherry-pick 2b77ca200c56
targos Jul 10, 2021
e3ecfa6
deps: V8: cherry-pick 56fe020eec0c
targos Jul 10, 2021
f9f5ff0
deps: V8: cherry-pick 3805a698f7b6
targos Jul 10, 2021
6449112
deps: V8: cherry-pick 359d44df4cdd
targos Jul 10, 2021
fad023d
deps: V8: backport 5c76da8ddcf8
targos Jul 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
deps: V8: backport 5c76da8ddcf8 
Original commit message:

    [mips][wasm][liftoff] Fix compile failed

    Port 2b77ca200c56667c68895e49c96c10ff77834f09

    Bug: v8:11809

    Change-Id: Idbbbc10d1339d6c8463686b6e701fb601a217cab
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2931557
    Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn>
    Auto-Submit: Liu yu <liuyu@loongson.cn>
    Cr-Commit-Position: refs/heads/master@{#74934}

Refs: v8/v8@5c76da8
  • Loading branch information
@targos
targos committed Jul 10, 2021
commit fad023dcdd7968cb8fbe9dc7120dfe0e6f5c1423
2 changes: 1 addition & 1 deletion common.gypi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.19',
'v8_embedder_string': '-node.20',

##### V8 defaults for Node.js #####

Expand Down
3 changes: 2 additions & 1 deletion deps/v8/src/wasm/baseline/mips/liftoff-assembler-mips.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,7 +491,8 @@ void LiftoffAssembler::StoreTaggedPointer(Register dst_addr,
void LiftoffAssembler::Load(LiftoffRegister dst, Register src_addr,
Register offset_reg, uint32_t offset_imm,
LoadType type, LiftoffRegList pinned,
uint32_t* protected_load_pc, bool is_load_mem) {
uint32_t* protected_load_pc, bool is_load_mem,
bool i64_offset) {
Register src = no_reg;
if (offset_reg != no_reg) {
src = GetUnusedRegister(kGpReg, pinned).gp();
Expand Down
3 changes: 2 additions & 1 deletion deps/v8/src/wasm/baseline/mips64/liftoff-assembler-mips64.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,8 @@ void LiftoffAssembler::StoreTaggedPointer(Register dst_addr,
void LiftoffAssembler::Load(LiftoffRegister dst, Register src_addr,
Register offset_reg, uintptr_t offset_imm,
LoadType type, LiftoffRegList pinned,
uint32_t* protected_load_pc, bool is_load_mem) {
uint32_t* protected_load_pc, bool is_load_mem,
bool i64_offset) {
MemOperand src_op = liftoff::GetMemOp(this, src_addr, offset_reg, offset_imm);

if (protected_load_pc) *protected_load_pc = pc_offset();
Expand Down