Skip to content

esm: refine ERR_REQUIRE_ESM errors #39175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
guybedford wants to merge 17 commits into from
Closed

esm: refine ERR_REQUIRE_ESM errors #39175

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
15babc4
esm: refine ERR_REQUIRE_ESM errors
guybedford Jun 27, 2021
8b6d578
fixup: space
guybedford Jun 27, 2021
0d129ba
fixup: arrow fn
guybedford Jun 27, 2021
7765a14
fixup: Apply suggestions from code review
guybedford Jun 27, 2021
187c7b9
fixup: pr feedback
guybedford Jun 28, 2021
8fbf23b
fixup: errors linting
guybedford Jun 28, 2021
fdd9b31
fixup: simplify internal stack frame hiding
guybedford Jul 8, 2021
af548b5
fixup: tests
guybedford Jul 8, 2021
cfe3db9
fixup: code review
guybedford Jul 12, 2021
78640e4
fixup: builtin require
guybedford Jul 12, 2021
16b687c
fixup: ERR_REQUIRE_ESM recommend "type": "commonjs"
guybedford Jul 12, 2021
e628c0a
fixup: line length
guybedford Jul 12, 2021
12b2009
fixup: tests
guybedford Jul 13, 2021
8871f4e
fixup: windows tests
guybedford Jul 14, 2021
dfd2397
fixup: more windows fixes
guybedford Jul 14, 2021
b156244
fixup: lazily load acorn
guybedford Jul 15, 2021
cf5879f
fixup: bootstrap list
guybedford Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fixup: lazily load acorn
  • Loading branch information
@guybedford
guybedford committed Jul 15, 2021
commit b156244365bbd30d11cdf712a232f5d1b9926372
3 changes: 1 addition & 2 deletions lib/internal/modules/cjs/helpers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@ let debug = require('internal/util/debuglog').debuglog('module', (fn) => {
debug = fn;
});

const parser = require('internal/deps/acorn/acorn/dist/acorn').Parser;

// TODO: Use this set when resolving pkg#exports conditions in loader.js.
const cjsConditions = new SafeSet(['require', 'node', ...userConditions]);

Expand Down Expand Up @@ -189,6 +187,7 @@ function normalizeReferrerURL(referrer) {

// For error messages only - used to check if ESM syntax is in use.
function hasEsmSyntax(code) {
const parser = require('internal/deps/acorn/acorn/dist/acorn').Parser;
let root;
try {
root = parser.parse(code, { sourceType: 'module', ecmaVersion: 'latest' });
Expand Down