Skip to content

readline: use logical assignment operators #39174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 1 commit into from
Closed

readline: use logical assignment operators #39174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
readline: use logical assignment operators 
With the addition of the new logical assignment operators (`||=`, `??=` and `&&=`), we could use it here.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva authored Jun 27, 2021
commit 6ed19e7864fab3fafdbf0e1f817b6c46d42069e3
4 changes: 2 additions & 2 deletions lib/readline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -975,7 +975,7 @@ Interface.prototype._moveCursor = function(dx) {
};

function _ttyWriteDumb(s, key) {
key = key || {};
key ||= {};

if (key.name === 'escape') return;

Expand Down Expand Up @@ -1025,7 +1025,7 @@ function _ttyWriteDumb(s, key) {
// Handle a write from the tty
Interface.prototype._ttyWrite = function(s, key) {
const previousKey = this._previousKey;
key = key || {};
key ||= {};
this._previousKey = key;

// Activate or deactivate substring search.
Expand Down