Skip to content

stream: fix pipeline pump #39006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ronag wants to merge 13 commits into from
Closed

stream: fix pipeline pump #39006

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
963f536
stream: fix pipeline pump
ronag Jun 11, 2021
5f05fd5
fixup
ronag Jun 11, 2021
f29bb2d
fixup
ronag Jun 11, 2021
1cd6a1c
Update lib/internal/streams/pipeline.js
ronag Jun 11, 2021
33c4e21
Apply suggestions from code review
ronag Jun 11, 2021
30b7e8d
fixup
ronag Jun 11, 2021
e6a62f4
Apply suggestions from code review
ronag Jun 11, 2021
2b453dc
fixup: test
ronag Jun 11, 2021
f12cc3d
fixup: test
ronag Jun 11, 2021
4e6be16
Update lib/internal/streams/pipeline.js
ronag Jun 11, 2021
2256818
fixup
ronag Jun 12, 2021
da4623a
fixup
ronag Jun 12, 2021
c23ab64
fixup
ronag Jun 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Apply suggestions from code review 
Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
  • Loading branch information
@ronag @aduh95
ronag and aduh95 authored Jun 11, 2021
commit e6a62f46bdd6da7bd423f11692275f245d61c937
14 changes: 8 additions & 6 deletions lib/internal/streams/pipeline.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,13 +14,15 @@ let eos;
const { once } = require('internal/util');
const destroyImpl = require('internal/streams/destroy');
const {
ERR_INVALID_ARG_TYPE,
ERR_INVALID_RETURN_VALUE,
ERR_MISSING_ARGS,
ERR_STREAM_DESTROYED,
ERR_STREAM_PREMATURE_CLOSE,
aggregateTwoErrors,
} = require('internal/errors').codes;
codes: {
ERR_INVALID_ARG_TYPE,
ERR_INVALID_RETURN_VALUE,
ERR_MISSING_ARGS,
ERR_STREAM_DESTROYED,
ERR_STREAM_PREMATURE_CLOSE,
},
} = require('internal/errors');

const { validateCallback } = require('internal/validators');

Expand Down