Skip to content

net: use missing validator #38984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 2 commits into from
Closed

net: use missing validator #38984

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d2dc64
net: use missing validator
VoltrexKeyva Jun 9, 2021
52269ec
fixup! net: use missing validator
VoltrexKeyva Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions lib/net.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,7 @@ const {
const { isUint8Array } = require('internal/util/types');
const {
validateAbortSignal,
validateFunction,
validateInt32,
validateNumber,
validatePort,
Expand Down Expand Up @@ -1002,10 +1003,7 @@ function lookupAndConnect(self, options) {
return;
}

if (options.lookup && typeof options.lookup !== 'function')
throw new ERR_INVALID_ARG_TYPE('options.lookup',
'Function', options.lookup);

if (options.lookup) validateFunction(options.lookup, 'options.lookup');
Comment thread
VoltrexKeyva marked this conversation as resolved.
Resolved

if (dns === undefined) dns = require('dns');
const dnsopts = {
Expand Down