lib: refactor debuglog init

PR-URL: #38838 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
aduh95 · Jun 12, 2021 · May 29, 2021 · Jun 12, 2021 · 423ae41625f47be4080de13e3760f50caca661c0
commit 423ae41625f47be4080de13e3760f50caca661c0
diff --git a/lib/internal/util/debuglog.js b/lib/internal/util/debuglog.js
@@ -1,36 +1,36 @@
 'use strict';
 
 const {
-  FunctionPrototypeBind,
   ObjectCreate,
   ObjectDefineProperty,
   RegExp,
-  RegExpPrototypeTest,
+  RegExpPrototypeExec,
   SafeArrayIterator,
   StringPrototypeToLowerCase,
   StringPrototypeToUpperCase,
 } = primordials;
 
 const { inspect, format, formatWithOptions } = require('internal/util/inspect');
 
-// `debugs` is deliberately initialized to undefined so any call to
-// debuglog() before initializeDebugEnv() is called will throw.
+// `debugImpls` and `testEnabled` are deliberately not initialized so any call
+// to `debuglog()` before `initializeDebugEnv()` is called will throw.
 let debugImpls;
-
-let debugEnvRegex = /^$/;
 let testEnabled;
 
+
 // `debugEnv` is initial value of process.env.NODE_DEBUG
 function initializeDebugEnv(debugEnv) {
   debugImpls = ObjectCreate(null);
   if (debugEnv) {
+    // This is run before any user code, it's OK not to use primordials.
     debugEnv = debugEnv.replace(/[|\\{}()[\]^$+?.]/g, '\\$&')
-      .replace(/\*/g, '.*')
-      .replace(/,/g, '$|^')
-      .toUpperCase();
-    debugEnvRegex = new RegExp(`^${debugEnv}$`, 'i');
+      .replaceAll('*', '.*')
+      .replaceAll(',', '$|^');
+    const debugEnvRegex = new RegExp(`^${debugEnv}$`, 'i');
+    testEnabled = (str) => RegExpPrototypeExec(debugEnvRegex, str) !== null;
+  } else {
+    testEnabled = () => false;
   }
-  testEnabled = FunctionPrototypeBind(RegExpPrototypeTest, null, debugEnvRegex);
 }
 
 // Emits warning when user sets