Skip to content

typings: add JSDoc typings for timers #38834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
VoltrexKeyva wants to merge 2 commits into from
Closed

typings: add JSDoc typings for timers #38834

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1420ef1
typings: add JSDoc typings for timers
VoltrexKeyva May 28, 2021
e94392c
fixup! typings: add JSDoc typings for timers
VoltrexKeyva Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! typings: add JSDoc typings for timers 
Fixed parameter type of `clearTimeout()` and `clearInterval()`.
  • Loading branch information
@VoltrexKeyva
VoltrexKeyva authored Jun 11, 2021
commit e94392cd5aad762c675d841eec58bf5c46a1fad2
4 changes: 2 additions & 2 deletions lib/timers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ ObjectDefineProperty(setTimeout, customPromisify, {

/**
* Cancels a timeout.
* @param {Timeout} timer
* @param {Timeout | string | number} timer
* @returns {void}
*/
function clearTimeout(timer) {
Expand Down Expand Up @@ -238,7 +238,7 @@ function setInterval(callback, repeat, arg1, arg2, arg3) {

/**
* Cancels an interval.
* @param {Timeout} timer
* @param {Timeout | string | number} timer
* @returns {void}
*/
function clearInterval(timer) {
Expand Down